Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757529Ab0DFSgd (ORCPT ); Tue, 6 Apr 2010 14:36:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755649Ab0DFSg1 (ORCPT ); Tue, 6 Apr 2010 14:36:27 -0400 Message-ID: <4BBB7F1E.3030307@redhat.com> Date: Tue, 06 Apr 2010 21:36:14 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: Dmitry Torokhov , Andrew Morton , "linux-kernel@vger.kernel.org" , "pv-drivers@vmware.com" Subject: Re: [PATCH] VMware Balloon driver References: <20100404215202.GA13020@dtor-ws.eng.vmware.com> <20100405142419.2c9bea3d.akpm@linux-foundation.org> <20100405225833.GA25970@dtor-ws.eng.vmware.com> <4BBB622F.4070501@redhat.com> <4BBB7CA3.2060802@goop.org> In-Reply-To: <4BBB7CA3.2060802@goop.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 31 On 04/06/2010 09:25 PM, Jeremy Fitzhardinge wrote: > On 04/06/2010 09:32 AM, Avi Kivity wrote: >> Yeah. If we wanted commonality, we could make a balloon_core.c that >> contains the common code. IMO that's premature, but perhaps there's >> some meat there (like suspend/resume support and /proc//sys interface). > > I think it would be useful to have common: > > 1. User and kernel mode ABIs for controlling ballooning. It assumes > that the different balloon implementations are sufficiently > similar in semantics. (Once there's a kernel ABI, adding a > common user ABI is trivial.) > 2. Policy driving the ballooning driver, at least from the guest > side. That is, some good metrics from the vm subsystem about > memory pressure (both positive and negative), and something to > turn those metrics into requests to the balloon driver. > > 1) is not a huge amount of code, but something consistent would be > nice. 2) is something we've been missing and is a bit of an open > question/research project anyway. 3) Code that attempts to reclaim 2MB pages when possible -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/