Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756151Ab0DGXGN (ORCPT ); Wed, 7 Apr 2010 19:06:13 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:57510 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756048Ab0DGXGJ (ORCPT ); Wed, 7 Apr 2010 19:06:09 -0400 Date: Thu, 8 Apr 2010 00:06:07 +0100 From: Al Viro To: Linus Torvalds Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Maciej Rutecki , Andrew Morton , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI Subject: Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33 Message-ID: <20100407230607.GM30031@ZenIV.linux.org.uk> References: <6Pphclm24fK.A.lSF.qsPvLB@chimera> <20100407221941.GL30031@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 39 On Wed, Apr 07, 2010 at 03:22:20PM -0700, Linus Torvalds wrote: > > > On Wed, 7 Apr 2010, Al Viro wrote: > > > > No, it's not the same thing; the fix is to have nfs ->d_revalidate() > > return an error on failing open attempt (in insane codepath that has > > ->d_revalidate() handling open()). Confirmed to work by reporter... > > Ok, can you do the proper changelog description and sign-offs etc? [PATCH] Have nfs ->d_revalidate() report errors properly If nfs atomic open implementation ends up doing open request from ->d_revalidate() codepath and gets an error from server, return that error to caller explicitly and don't bother with lookup_instantiate_filp() at all. ->d_revalidate() can return an error itself just fine... Signed-off-by: Al Viro --- diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d79a7b3..fe0cd9e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st case -EDQUOT: case -ENOSPC: case -EROFS: - lookup_instantiate_filp(nd, (struct dentry *)state, NULL); - return 1; + return PTR_ERR(state); default: goto out_drop; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/