Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758122Ab0DHAbM (ORCPT ); Wed, 7 Apr 2010 20:31:12 -0400 Received: from kroah.org ([198.145.64.141]:60461 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756119Ab0DHAbJ (ORCPT ); Wed, 7 Apr 2010 20:31:09 -0400 Date: Wed, 7 Apr 2010 17:26:26 -0700 From: Greg KH To: =?utf-8?Q?Micha=C5=82?= Nazarewicz Cc: linux-usb@vger.kernel.org, Peter Korsgaard , Rupesh Gujare , linux-kernel@vger.kernel.org, David Brownell , Kyungmin Park , Marek Szyprowski Subject: Re: [PATCH 1/8] USB: composite: allow optional removal of __init and __exit tags Message-ID: <20100408002626.GA4365@kroah.com> References: <033ad254a3bba337e7a37cc6071b7debc7051801.1270644740.git.mina86@mina86.com> <20100407152852.GA13425@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 29 On Wed, Apr 07, 2010 at 05:39:35PM +0200, Michał Nazarewicz wrote: > >On Wed, Apr 07, 2010 at 03:41:28PM +0200, Michal Nazarewicz wrote: > >>The composite framework has been written using __init and __exit tags > >>to mark init and exit functions as such. This works with most of the > >>composite gadgets however some may need to call init/exit functions > >>during normal operations. One example is mass storage gadget which > >>needs to call exit functions. > >> > >>This patch allows gadgets to define USB_NO_INIT_SEGMENT or > >>USB_NO_EXIT_SEGMENT to remove the __init and __exit declarations > >>from composite framework. > > On Wed, 07 Apr 2010 17:28:52 +0200, Greg KH wrote: > >How about we just drop the __init and __exit tags completly and then > >we don't have to propagate this mess any further? > > Personally, I don't care, ;) so if you think it's better to drop it all > together I can change it in a future patch. That would be great. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/