Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758214Ab0DHAbd (ORCPT ); Wed, 7 Apr 2010 20:31:33 -0400 Received: from kroah.org ([198.145.64.141]:60477 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758103Ab0DHAbM (ORCPT ); Wed, 7 Apr 2010 20:31:12 -0400 Date: Wed, 7 Apr 2010 17:30:58 -0700 From: Greg KH To: Michal Nazarewicz Cc: linux-usb@vger.kernel.org, Peter Korsgaard , Rupesh Gujare , linux-kernel@vger.kernel.org, David Brownell , Kyungmin Park , Marek Szyprowski Subject: Re: [PATCH 8/8] USB: testusb: testusb compatibility with FunctionFS gadget Message-ID: <20100408003058.GD4365@kroah.com> References: <033ad254a3bba337e7a37cc6071b7debc7051801.1270644740.git.mina86@mina86.com> <922265f162fd3b45408c234d0d17e924b6f61671.1270644740.git.mina86@mina86.com> <15d6fb76583235c380569d11d904cc0e8d019067.1270644740.git.mina86@mina86.com> <3c4f11cdfb08952e964879c343d6ed7ceedc9542.1270644740.git.mina86@mina86.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 30 On Wed, Apr 07, 2010 at 03:41:35PM +0200, Michal Nazarewicz wrote: > The FunctionFS gadget may provide the source/sink interface > not as the first interface (with id == 0) but some different > interface hence a code to find the interface number is > required. > > (Note that you will still configure the gadget to report > idProduct == 0xa4a4 (an "echo 0xa4a4 > >/sys/module/g_ffs/parameters/usb_product" should suffice) or > configure host to handle 0x0525:0xa4ac devices using the > usbtest driver.) > > Signed-off-by: Michal Nazarewicz > Cc: Kyungmin Park > Cc: Marek Szyprowski Ah, kernel code with a userspace test program. If only all patches came with stuff like this. Very nice job, I like it a lot. Care to take the minor comments so far, and redo it? I'll be glad to take the patches into my tree then. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/