Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756969Ab0DHGSn (ORCPT ); Thu, 8 Apr 2010 02:18:43 -0400 Received: from kroah.org ([198.145.64.141]:57855 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab0DHGSm (ORCPT ); Thu, 8 Apr 2010 02:18:42 -0400 Date: Wed, 7 Apr 2010 23:18:46 -0700 From: Greg KH To: Heikki Krogerus Cc: ext Michal Nazarewicz , "linux-usb@vger.kernel.org" , Peter Korsgaard , Rupesh Gujare , "linux-kernel@vger.kernel.org" , David Brownell , Kyungmin Park , Marek Szyprowski Subject: Re: [PATCH 7/8] USB: testusb: imported David Brownell's USB testing application Message-ID: <20100408061846.GA29184@kroah.com> References: <033ad254a3bba337e7a37cc6071b7debc7051801.1270644740.git.mina86@mina86.com> <922265f162fd3b45408c234d0d17e924b6f61671.1270644740.git.mina86@mina86.com> <15d6fb76583235c380569d11d904cc0e8d019067.1270644740.git.mina86@mina86.com> <3c4f11cdfb08952e964879c343d6ed7ceedc9542.1270644740.git.mina86@mina86.com> <20100408061000.GA7606@esdhcp042221.research.nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100408061000.GA7606@esdhcp042221.research.nokia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 35 On Thu, Apr 08, 2010 at 09:10:00AM +0300, Heikki Krogerus wrote: > Hi, > > If this is going into kernel then.. > > On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote: > > ... > > > + if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) { > > + fputs ("usbfs files are missing\n", stderr); > > + return -1; > > + } > > Is this needed? > > > + > > + /* collect and list the test devices */ > > + if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) { > > How about "/dev/bus/usb" instead? Some distributions do not enable > sysfs in their default kernels anymore. You mean 'usbfs' not 'sysfs', right? And yes, this probably should be fixed, patches are always welcome :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/