Date: Thu, 8 Apr 2010 14:46:30 +0200
From: Jens Axboe <jens.axboe@oracle.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Divyesh Shah <dpshah@google.com>, vgoyal@redhat.com,
       linux-kernel@vger.kernel.org, nauman@google.com, ctalbott@google.com
Subject: Re: [PATCH][v3.1] blkio: Add io controller stats like
Message-ID: <20100408124629.GN10103@kernel.dk>
References: <20100406232533.25602.46349.stgit@austin.mtv.corp.google.com> <4BBD3DB9.8090006@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BBD3DB9.8090006@cn.fujitsu.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1471
Lines: 36

On Thu, Apr 08 2010, Gui Jianfeng wrote:
> Divyesh Shah wrote:
> > - io_service_time (the total time between request dispatch and completion for
> >   all IOs in the cgroup)
> > - io_wait_time (the total time spent waiting by all IOs in this cgroup in the IO
> >   scheduler queues before getting serviced)
> > - io_serviced (number of IOs serviced from this blkio_group)
> > - io_service_bytes (Number of bytes served for this cgroup)
> > 
> > These stats are accumulated per operation type helping us to distinguish between
> > read and write, and sync and async IO. This patch does not increment any of
> > these stats.
> > 
> > Changelog from v3:
> > o renamed blkiocg_reset_write to blkiocg_reset_stats
> > o more clarification in the documentation on io_service_time and io_wait_time.
> > 
> > Signed-off-by: Divyesh Shah<dpshah@google.com>
> 
> Hi Divyesh,
> 
> Jens has already applied previous patchset to for-2.6.35 branch, so v3 patchset
> and this patch have conflicts with for-2.6.35 branch. I think it's better to make
> new patch on top of for-2.6.35.

Thanks, was just about to ask. Please make an updated patch against what
I already have, so I don't have to revert/rebase to make this work.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/