Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751431Ab0DIBpX (ORCPT ); Thu, 8 Apr 2010 21:45:23 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:58350 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043Ab0DIBpW (ORCPT ); Thu, 8 Apr 2010 21:45:22 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Linus Torvalds Subject: Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA Cc: kosaki.motohiro@jp.fujitsu.com, Borislav Petkov , Rik van Riel , Andrew Morton , Minchan Kim , Linux Kernel Mailing List , Lee Schermerhorn , Nick Piggin , Andrea Arcangeli , Hugh Dickins , sgunderson@bigfoot.com, hannes@cmpxchg.org In-Reply-To: References: <20100408234721.GB25834@a1.tnic> Message-Id: <20100409104345.80DA.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Fri, 9 Apr 2010 10:45:17 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 35 > > > On Fri, 9 Apr 2010, Borislav Petkov wrote: > > > > Yep, looks good: its mmap_region()... > > Can you double-check your current diffs - maybe something got corrupted. > > mmap_region installs the vma with vma_link(), and the last thing > vma_link() does with my patch is that "anon_vma_prepare()". I agree. and at least your patch works fine on my box. I'll continue digg. > > Maybe with all the patches flying around, you had a reject or something, > and you lost that one anon_vma_prepare()? > > Or maybe I screwed up somewhere and sent you the wrong patch. Here it is > again, just in case. > > [ I have a horrible cold, and can hardly think straight. So who knows, > maybe I'm missing something. But if you have lost one of the > 'anon_vma_prepare()' call sites, that would certainly explain why you > get NULL anon_vma's ] > > Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/