Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756Ab0DIQtP (ORCPT ); Fri, 9 Apr 2010 12:49:15 -0400 Received: from smtp-out.google.com ([74.125.121.35]:55022 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869Ab0DIQtO (ORCPT ); Fri, 9 Apr 2010 12:49:14 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=LQbhoRXSj66BLA4Mu0tQ+rq+6cSa+XImRNhaqFy48rLtW7TAbGQ1agKT7M7yUWxfg /tjaij11RwebJnyzvNd3A== Date: Fri, 9 Apr 2010 09:49:05 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Xiaotian Feng cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Matt Mackall , Vegard Nossum , Dmitry Monakhov , Catalin Marinas Subject: Re: [PATCH] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING In-Reply-To: <4BBEC92B.9060407@redhat.com> Message-ID: References: <1270721493-27820-1-git-send-email-dfeng@redhat.com> <4BBEC92B.9060407@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 20 On Fri, 9 Apr 2010, Xiaotian Feng wrote: > > This doesn't work if the underlying slab allocator doesn't define > > __kmalloc_node_track_caller() regardless of whether CONFIG_TRACING is > > enabled or not. SLOB, for example, never defines it, and that's why the > > conditional exists in the way it currently does. > > > > Sorry, I didn't realized this, can we use (defined(CONFIG_TRACING) && > defined(CONFIG_SLAB)) ? > The valid configurations are (CONFIG_SLAB && (CONFIG_DEBUG_SLAB || CONFIG_TRACING)) || CONFIG_SLUB -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/