Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757Ab0DKSkO (ORCPT ); Sun, 11 Apr 2010 14:40:14 -0400 Received: from legolas.restena.lu ([158.64.1.34]:46509 "EHLO legolas.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693Ab0DKSkM (ORCPT ); Sun, 11 Apr 2010 14:40:12 -0400 Date: Sun, 11 Apr 2010 20:40:02 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jiri Kosina Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum Subject: Re: [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Message-ID: <20100411204002.6ba32f43@neptune.home> In-Reply-To: References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> <20100326102951.3b9ecda1@neptune.home> <20100327012245.0ace6a09@neptune.home> <20100329121611.0c22dcaf@pluto.restena.lu> <20100330223224.18fe4f3e@neptune.home> <20100330224230.7b84df75@neptune.home> <20100411130226.4086a92d@neptune.home> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 20 On Sun, 11 April 2010 Jiri Kosina wrote: > > As far as I understand the code, in auto-suspend case if the driver > > sends commands to the device it will have to call usbhid_wait_io(). > > Please correct me if I'm wrong! > > It's not needed. There is a queuing mechanism in place on > 'resumption_waker' workqueue. So the driver is not allowed to ask the device to do something at auto-suspend time (as that would abort the auto-suspension). Am I right? Thanks, Bruno -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/