From: Oliver Neukum <oliver@neukum.org>
To: Bruno =?iso-8859-1?q?Pr=E9mont?= <bonbons@linux-vserver.org>
Subject: Re: [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers
Date: Sun, 11 Apr 2010 22:27:32 +0200
User-Agent: KMail/1.12.4 (Linux/2.6.34-rc3-0.1-default; KDE/4.3.5; x86_64; ; )
Cc: Jiri Kosina <jkosina@suse.cz>, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
       linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
       linux-kernel@vger.kernel.org,
       "Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>,
       Nicu Pavel <npavel@ituner.com>
References: <20100324233707.7243b04d@neptune.home> <alpine.LNX.2.00.1004112029220.8345@pobox.suse.cz> <20100411204002.6ba32f43@neptune.home>
In-Reply-To: <20100411204002.6ba32f43@neptune.home>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Message-Id: <201004112227.32045.oliver@neukum.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 926
Lines: 24

Am Sonntag, 11. April 2010 20:40:02 schrieb Bruno Pr?mont:
> On Sun, 11 April 2010 Jiri Kosina <jkosina@suse.cz> wrote:
> > > As far as I understand the code, in auto-suspend case if the driver 
> > > sends commands to the device it will have to call usbhid_wait_io(). 
> > > Please correct me if I'm wrong!
> > 
> > It's not needed. There is a queuing mechanism in place on 
> > 'resumption_waker' workqueue.
> 
> So the driver is not allowed to ask the device to do something
> at auto-suspend time (as that would abort the auto-suspension).

>From within suspend()?

Generally if the driver wants to talk to a device that's a good
reason to wake up a device.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/