Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161Ab0DKWYm (ORCPT ); Sun, 11 Apr 2010 18:24:42 -0400 Received: from www.tglx.de ([62.245.132.106]:35344 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003Ab0DKWYl (ORCPT ); Sun, 11 Apr 2010 18:24:41 -0400 Date: Mon, 12 Apr 2010 00:24:10 +0200 (CEST) From: Thomas Gleixner To: Pavel Machek cc: Geert Uytterhoeven , Alexey Dobriyan , kernel list , Linus Torvalds , Andrew Morton Subject: Re: LOCALVERSION_AUTO considered harmful In-Reply-To: <20100411201426.GC25294@elf.ucw.cz> Message-ID: References: <20100411164701.GA7558@elf.ucw.cz> <20100412185136.GA13171@x200> <20100411201426.GC25294@elf.ucw.cz> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-2080386426-1271024652=:18009" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1853 Lines: 48 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-2080386426-1271024652=:18009 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT On Sun, 11 Apr 2010, Pavel Machek wrote: > On Sun 2010-04-11 20:58:58, Geert Uytterhoeven wrote: > > On Mon, Apr 12, 2010 at 20:51, Alexey Dobriyan wrote: > > > On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote: > > >> @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO > > >> ? ? ? ? appended after any matching localversion* files, and after the value > > >> ? ? ? ? set in CONFIG_LOCALVERSION. > > >> > > >> + ? ? ? Unfortunately, such finegrained versioning will mean that you will > > >> + ? ? ? not be able to use modules for development; even "make modules" > > >> + ? ? ? will change module versions, making recompiled modules impossible > > >> + ? ? ? to insert into old kernel. > > > > > > That's conditional BS. > > > Turn off CONFIG_MODVERSIONS already. > > > > Yeah, I disabled it ages ago. Even then (before git, probably even > > before bitkeeper) > > I had hard times inserting modules... > > I _had_ it off > > # CONFIG_MODVERSIONS is not set > > It seems some checking survives CONFIG_MODVERSIONS unset and that > checking is strict enough to refuse module load after one "make > modules" with LOCALVERSION_AUTO on... So instead of fixing the CONFIG_MODVERSIONS=n case you go the easy way of killing LOCALVERSION_AUTO ? Brilliant. Thanks, tglx --8323328-2080386426-1271024652=:18009-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/