Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753374Ab0DLTtz (ORCPT ); Mon, 12 Apr 2010 15:49:55 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:53725 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876Ab0DLTtx (ORCPT ); Mon, 12 Apr 2010 15:49:53 -0400 Subject: Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA From: Peter Zijlstra To: Linus Torvalds Cc: Rik van Riel , Borislav Petkov , Johannes Weiner , KOSAKI Motohiro , Andrew Morton , Minchan Kim , Linux Kernel Mailing List , Lee Schermerhorn , Nick Piggin , Andrea Arcangeli , Hugh Dickins , sgunderson@bigfoot.com In-Reply-To: <1271100621.20295.3397.camel@laptop> References: <20100409191425.GB10780@a1.tnic> <20100409204328.GG28964@cmpxchg.org> <20100410003110.GI28964@cmpxchg.org> <20100410072714.GA9246@liondog.tnic> <20100410112639.GA24708@a1.tnic> <20100410163828.GA25579@a1.tnic> <1271083207.4807.18.camel@twins> <4BC33A02.8000307@redhat.com> <1271088103.20295.3383.camel@laptop> <4BC34501.5060401@redhat.com> <1271097638.4807.129.camel@twins> <1271100621.20295.3397.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 12 Apr 2010 21:44:34 +0200 Message-ID: <1271101474.20295.3400.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 19 On Mon, 2010-04-12 at 21:30 +0200, Peter Zijlstra wrote: > > We could here return a non-valid and already freed anon_vma. > OK, so non of the users of page_lock_anon_vma() with exception of the memory-failure.c one could really care. And all of them seem to be safe enough wrt dealing with a dead one. So unless people care, I'm going to not spend more time on trying to make page_lock_anon_vma() behave. Instead I'll try and see wth it is that migrate.c and rmap_walk_anon are doing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/