Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216Ab0DLWQb (ORCPT ); Mon, 12 Apr 2010 18:16:31 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49384 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006Ab0DLWQa (ORCPT ); Mon, 12 Apr 2010 18:16:30 -0400 Date: Mon, 12 Apr 2010 15:11:53 -0700 (PDT) From: Linus Torvalds To: Borislav Petkov cc: Johannes Weiner , KOSAKI Motohiro , Rik van Riel , Andrew Morton , Minchan Kim , Linux Kernel Mailing List , Lee Schermerhorn , Nick Piggin , Andrea Arcangeli , Hugh Dickins , sgunderson@bigfoot.com Subject: Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA In-Reply-To: <20100412215027.GA6263@liondog.tnic> Message-ID: References: <20100410215115.GA2599@a1.tnic> <20100411130801.GA7189@a1.tnic> <20100411185508.GA4450@liondog.tnic> <20100412072056.GA2432@liondog.tnic> <20100412215027.GA6263@liondog.tnic> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 40 On Mon, 12 Apr 2010, Borislav Petkov wrote: > > > I have a new theory. And this new theory is completely different from all > > the other things we've been looking at. > > Yeah, because all starts with "I have a new theory..." :o) Hey, all my other theories made sense too.. They just didn't work. But as Edison said: I didn't fail, I just found three other ways to not fix your bug. > > The patch below is my largely mindless try at fixing this. It's untested. > > I'm not entirely sure that it actually works. But it makes some amount of > > conceptual sense. No? > > Linus, are you trying to give me a heart-attack? This sh*t just survived > 20(!) hibernation runs without a problem (well, there is this nagging > /sysfs lockdep warning) but apart from that, it survived! I even did my > all time best when hitting on it. Normally, it used to crap up on the > 6th cycle as latest. Now we're rock solid. And yes, there were something > like ~64Mb in the swap cache. > > Also, I have your verification stuff in addition to the 4 patches you > sent before. Not a single WARN_ONCE got triggered. So I have a gut > feeling that it is fixed but you never know with these beasts. Ok. That does sound very positive. Of course, last time you sounded positive, I had an email from you half an hour later that said "oh no, it oopsed again". So I'll take it with a bit of salt, but on the whole I'll be optimistic about it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/