Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383Ab0DMJcr (ORCPT ); Tue, 13 Apr 2010 05:32:47 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:52452 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439Ab0DMJcq (ORCPT ); Tue, 13 Apr 2010 05:32:46 -0400 Message-ID: <4BC43A3C.7010603@cs.helsinki.fi> Date: Tue, 13 Apr 2010 12:32:44 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: TAO HU , Nick Piggin CC: linux-kernel@vger.kernel.org, cl@linux-foundation.org, mpm@selenic.com, linux-mm@kvack.org, dwmw2@infradead.org, TAO HU , ShiYong LI , david.rientjes@google.com Subject: Re: [PATCH - V2] Fix missing of last user while dumping slab corruption log References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 32 TAO HU kirjoitti: > Actually we greped "kmem_cache_create" in whole kernel souce tree > (2.6.29 and 2.6.32). > > Either "align" equal to "0" or flag SLAB_HWCACHE_ALIGN is used when > calling kmem_cache_create(). I don't think that's correct. The "task_xstate" has alignof(struct task_xstate) and there seems to be so GCC attributes that force non-default alignment on the struct. > Seems all of arch's cache-line-size is multiple of 64-bit/8-byte > (sizeof(long long)) except arch-microblaze (4-byte). > The smallest (except arch-microblaze) cache-line-size is 2^4= 16-byte > as I can see. > So even considering possible sizeof(long long) == 128-bit/16-byte, it > is still safe to apply Shiyong's original version. > > Anyway, Shiyong's new patch check the weired situation that "align > > sizeof(long long) && align is NOT multiple of sizeof (long long)" > Let us know whether the new version address your concerns. Yeah, sorry for dragging this issue on. I've been looking at the patch but haven't been able to convince myself that it's correct. Nick, David, Christoph, Matt, could you also please take a look at this? Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/