Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752878Ab0DMPcn (ORCPT ); Tue, 13 Apr 2010 11:32:43 -0400 Received: from gir.skynet.ie ([193.1.99.77]:59193 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819Ab0DMPcm (ORCPT ); Tue, 13 Apr 2010 11:32:42 -0400 Date: Tue, 13 Apr 2010 16:32:23 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/6] Remove node's validity check in alloc_pages Message-ID: <20100413153223.GB25756@csn.ul.ie> References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 45 On Wed, Apr 14, 2010 at 12:24:58AM +0900, Minchan Kim wrote: > alloc_pages calls alloc_pages_node with numa_node_id(). > alloc_pages_node can't see nid < 0. > > So we can use alloc_pages_exact_node instead of alloc_pages_node. > It could avoid comparison and branch as 6484eb3e2a81807722 tried. > > Cc: Mel Gorman > Cc: KAMEZAWA Hiroyuki > Signed-off-by: Minchan Kim Makes sense. Signed-off-by: Mel Gorman > --- > include/linux/gfp.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 4c6d413..b65f003 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -308,7 +308,7 @@ extern struct page *alloc_page_vma(gfp_t gfp_mask, > struct vm_area_struct *vma, unsigned long addr); > #else > #define alloc_pages(gfp_mask, order) \ > - alloc_pages_node(numa_node_id(), gfp_mask, order) > + alloc_pages_exact_node(numa_node_id(), gfp_mask, order) > #define alloc_page_vma(gfp_mask, vma, addr) alloc_pages(gfp_mask, 0) > #endif > #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0) > -- > 1.7.0.5 > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/