Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312Ab0DMQOm (ORCPT ); Tue, 13 Apr 2010 12:14:42 -0400 Received: from gir.skynet.ie ([193.1.99.77]:47140 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260Ab0DMQOk (ORCPT ); Tue, 13 Apr 2010 12:14:40 -0400 Date: Tue, 13 Apr 2010 17:14:22 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Lameter Subject: Re: [PATCH 3/6] change alloc function in alloc_slab_page Message-ID: <20100413161421.GH25756@csn.ul.ie> References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> <8b348d9cc1ea4960488b193b7e8378876918c0d4.1271171877.git.minchan.kim@gmail.com> <20100413155253.GD25756@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 34 On Wed, Apr 14, 2010 at 01:01:31AM +0900, Minchan Kim wrote: > On Wed, Apr 14, 2010 at 12:52 AM, Mel Gorman wrote: > > On Wed, Apr 14, 2010 at 12:25:00AM +0900, Minchan Kim wrote: > >> alloc_slab_page never calls alloc_pages_node with -1. > > > > Are you certain? What about > > > > __kmalloc > > ?-> slab_alloc (passed -1 as a node from __kmalloc) > > ? ?-> __slab_alloc > > ? ? ?-> new_slab > > ? ? ? ?-> allocate_slab > > ? ? ? ? ?-> alloc_slab_page > > > > Sorry for writing confusing changelog. > > I means if node == -1 alloc_slab_page always calls alloc_pages. > So we don't need redundant check. > When the changelog is fixed up, feel free to add; Reviewed-by: Mel Gorman -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/