Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243Ab0DMSHc (ORCPT ); Tue, 13 Apr 2010 14:07:32 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:52255 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863Ab0DMSHa (ORCPT ); Tue, 13 Apr 2010 14:07:30 -0400 Date: Tue, 13 Apr 2010 14:07:30 -0400 From: Christoph Hellwig To: Dmitry Monakhov Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com, hch@infradead.org Subject: Re: [PATCH 4/4] patch blk-add-zeroout-helper.patch Message-ID: <20100413180730.GF21302@infradead.org> References: <1271077437-7921-1-git-send-email-dmonakhov@openvz.org> <1271077437-7921-2-git-send-email-dmonakhov@openvz.org> <1271077437-7921-3-git-send-email-dmonakhov@openvz.org> <1271077437-7921-4-git-send-email-dmonakhov@openvz.org> <1271077437-7921-5-git-send-email-dmonakhov@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1271077437-7921-5-git-send-email-dmonakhov@openvz.org> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 418 Lines: 12 Looks okayish to me, but it really needs: a) a useful patch description b) patches that introduce actual users Also why does the function have a __ prefix in the name? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/