Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754186Ab0DNAIL (ORCPT ); Tue, 13 Apr 2010 20:08:11 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:47450 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789Ab0DNAIJ (ORCPT ); Tue, 13 Apr 2010 20:08:09 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Wed, 14 Apr 2010 09:04:13 +0900 From: KAMEZAWA Hiroyuki To: Minchan Kim Cc: Andrew Morton , Mel Gorman , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/6] Remove node's validity check in alloc_pages Message-Id: <20100414090413.71376da1.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.2 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 22 On Wed, 14 Apr 2010 00:24:58 +0900 Minchan Kim wrote: > alloc_pages calls alloc_pages_node with numa_node_id(). > alloc_pages_node can't see nid < 0. > > So we can use alloc_pages_exact_node instead of alloc_pages_node. > It could avoid comparison and branch as 6484eb3e2a81807722 tried. > > Cc: Mel Gorman > Cc: KAMEZAWA Hiroyuki > Signed-off-by: Minchan Kim Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/