Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751645Ab0DNEfv (ORCPT ); Wed, 14 Apr 2010 00:35:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14316 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003Ab0DNEfu (ORCPT ); Wed, 14 Apr 2010 00:35:50 -0400 Message-ID: <4BC546CF.9020004@redhat.com> Date: Wed, 14 Apr 2010 12:38:39 +0800 From: Cong Wang User-Agent: Thunderbird 2.0.0.23 (X11/20091001) MIME-Version: 1.0 To: penguin-kernel@i-love.sakura.ne.jp CC: rolandd@cisco.com, sean.hefty@intel.com, opurdila@ixiacom.com, eric.dumazet@gmail.com, netdev@vger.kernel.org, nhorman@tuxdriver.com, davem@davemloft.net, ebiederm@xmission.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Infiniband: Randomize local port allocation. References: <20100412100744.5302.92442.sendpatchset@localhost.localdomain> <20100412100816.5302.74919.sendpatchset@localhost.localdomain> <201004130121.o3D1Lhh7099571@www262.sakura.ne.jp> <4BC41994.7030707@redhat.com> <4BC42FE0.4040601@redhat.com> <201004132207.GAJ52684.OJFtMQVFHOSFLO@I-love.SAKURA.ne.jp> <21DAC78125424ED291B5D6477CFF9657@amr.corp.intel.com> <201004140201.o3E21Aqn075978@www262.sakura.ne.jp> In-Reply-To: <201004140201.o3E21Aqn075978@www262.sakura.ne.jp> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 31 penguin-kernel@i-love.sakura.ne.jp wrote: > Sean Hefty wrote: >> Sean and Roland, is below patch correct? >>> inet_is_reserved_local_port() is the new function proposed in this patchset. >> It looks correct to me. I didn't test the patch series, but if I comment out >> the call to inet_is_reserved_local_port() in the provided below, the changes >> worked fine for me. >> >> Acked-by: Sean Hefty >> > Thank you for testing. > > I think it is better to split this patch into > > Part 1: Make cma_alloc_any_port() to use cma_alloc_port(). > > Part 2: Insert "!inet_is_reserved_local_port(rover) &&" line. > > for future "git bisect". > Right, thanks a lot for your work! So, I will rebase my patch 3/3 on top of this patch. I hope someone could take this one asap. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/