Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753875Ab0DNGPW (ORCPT ); Wed, 14 Apr 2010 02:15:22 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:38005 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753462Ab0DNGPU (ORCPT ); Wed, 14 Apr 2010 02:15:20 -0400 Message-ID: <4BC55D72.7080301@jp.fujitsu.com> Date: Wed, 14 Apr 2010 15:15:14 +0900 From: Tomohiro Kusumi User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: "linux-scsi@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: [PATCH] fix sdev_rw_attr macro for scsi device sysfs entries Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 47 Hi This patch fixes sdev_rw_attr() macro for scsi device sysfs entries. It seems there is no such function snscanf in the current linux kernel, so it fails to compile scsi driver when someone try to add a new rw entry. This has been unfixed for a long time probably because current scsi device has no rw entries. # grep snscanf . -rn ./drivers/scsi/scsi_sysfs.c:489: snscanf (buf, 20, format_string, &sdev->field); \ Thanks, Tomohiro Kusumi Signed-off-by: Tomohiro Kusumi --- diff -aNur linux-2.6.34-rc4.org/drivers/scsi/scsi_sysfs.c linux-2.6.34-rc4/drivers/scsi/scsi_sysfs.c --- linux-2.6.34-rc4.org/drivers/scsi/scsi_sysfs.c 2010-04-13 10:41:35.000000000 +0900 +++ linux-2.6.34-rc4/drivers/scsi/scsi_sysfs.c 2010-04-14 15:05:50.000000000 +0900 @@ -474,7 +474,7 @@ /* - * sdev_rd_attr: create a function and attribute variable for a + * sdev_rw_attr: create a function and attribute variable for a * read/write field. */ #define sdev_rw_attr(field, format_string) \ @@ -486,7 +486,7 @@ { \ struct scsi_device *sdev; \ sdev = to_scsi_device(dev); \ - snscanf (buf, 20, format_string, &sdev->field); \ + sscanf (buf, format_string, &sdev->field); \ return count; \ } \ static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, sdev_show_##field, sdev_store_##field); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/