Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753626Ab0DPFdm (ORCPT ); Fri, 16 Apr 2010 01:33:42 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:52552 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753268Ab0DPFdk (ORCPT ); Fri, 16 Apr 2010 01:33:40 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Minchan Kim Subject: Re: [PATCH] vmscan: page_check_references() check low order lumpy reclaim properly Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang , Andreas Mohr , Jens Axboe , Linux Memory Management List , "linux-kernel@vger.kernel.org" , Rik van Riel , Lee Schermerhorn In-Reply-To: References: <20100416115437.27AD.A69D9226@jp.fujitsu.com> Message-Id: <20100416143134.27B9.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Fri, 16 Apr 2010 14:33:36 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 33 > > +       /* > > +        * If we need a large contiguous chunk of memory, or have > > +        * trouble getting a small set of contiguous pages, we > > +        * will reclaim both active and inactive pages. > > +        */ > > +       if (sc->order > PAGE_ALLOC_COSTLY_ORDER) > > +               sc->lumpy_reclaim = 1; > > +       else if (sc->order && priority < DEF_PRIORITY - 2) > > +               sc->lumpy_reclaim = 1; > > +       else > > +               sc->lumpy_reclaim = 0; > > How about making new function for readability instead of nesting else? > int is_lumpy_reclaim(struct scan_control *sc) > { > .... > } > > If you merge patch reduced stack usage of reclaim path, I think it's > enough alone scan_control argument. > It's just nitpick. :) > If you don't mind, ignore, please. Good opinion. I don't hope introduce the dependency of "reduced stack usage" series. but I agree that I'll push your proposal later and separately. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/