Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758290Ab0DPQJJ (ORCPT ); Fri, 16 Apr 2010 12:09:09 -0400 Received: from nlpi157.sbcis.sbc.com ([207.115.36.171]:50347 "EHLO nlpi157.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871Ab0DPQJF (ORCPT ); Fri, 16 Apr 2010 12:09:05 -0400 Date: Fri, 16 Apr 2010 11:07:55 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Minchan Kim cc: Tejun Heo , Mel Gorman , Andrew Morton , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages In-Reply-To: Message-ID: References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> <4BC65237.5080408@kernel.org> <4BC6BE78.1030503@kernel.org> <4BC6CB30.7030308@kernel.org> <4BC6E581.1000604@kernel.org> <4BC6FBC8.9090204@kernel.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 27 On Thu, 15 Apr 2010, Minchan Kim wrote: > I don't want to remove alloc_pages for UMA system. alloc_pages is the same as alloc_pages_any_node so why have it? > #define alloc_pages alloc_page_sexact_node > > What I want to remove is just alloc_pages_node. :) Why remove it? If you want to get rid of -1 handling then check all the callsites and make sure that they are not using -1. Also could you define a constant for -1? -1 may have various meanings. One is the local node and the other is any node. The difference is if memory policies are obeyed or not. Note that alloc_pages follows memory policies whereas alloc_pages_node does not. Therefore alloc_pages() != alloc_pages_node( , -1) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/