Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754557Ab0DQTfA (ORCPT ); Sat, 17 Apr 2010 15:35:00 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40928 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754177Ab0DQTe7 (ORCPT ); Sat, 17 Apr 2010 15:34:59 -0400 Date: Sat, 17 Apr 2010 21:34:38 +0200 From: Ingo Molnar To: Avi Kivity Cc: "Zhang, Yanmin" , Peter Zijlstra , Sheng Yang , Marcelo Tosatti , oerg Roedel , kvm@vger.kernel.org, Jes Sorensen , linux-kernel@vger.kernel.org, Zachary Amsden , Gleb Natapov , tim.c.chen@intel.com, zhiteng.huang@intel.com, Arnaldo Carvalho de Melo Subject: Re: [PATCH V4 1/2] perf & kvm: Enhance perf to collect KVM guest os statistics from host side Message-ID: <20100417193438.GA5155@elte.hu> References: <1271403275.2078.509.camel@ymzhang.sh.intel.com> <4BC9FC9A.6050807@redhat.com> <20100417191308.GA25160@elte.hu> <4BCA092A.8050308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BCA092A.8050308@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 50 * Avi Kivity wrote: > On 04/17/2010 10:13 PM, Ingo Molnar wrote: > >* Avi Kivity wrote: > > > >>On 04/16/2010 10:34 AM, Zhang, Yanmin wrote: > >>>Below is the kernel patch to enable perf to collect guest os statistics. > >>> > >>>Joerg, > >>> > >>>Would you like to add support on svm? I don't know the exact point to trigger > >>>NMI to host with svm. > >>> > >>>See below code with vmx: > >>> > >>>+ kvm_before_handle_nmi(&vmx->vcpu); > >>> asm("int $2"); > >>>+ kvm_after_handle_nmi(&vmx->vcpu); > >>> > >>>Signed-off-by: Zhang Yanmin > >>Can you please split it further? > >> > >>Patch 1 introduces perf_register_guest_info_callbacks() and related. Ingo > >>can merge this into a branch in tip.git. Patch 2 is just the kvm bits, I'll > >>apply that after merging the branch with patch 1. Patch 3 adds the > >>tools/perf changes. > >> > >>This way perf development can continue on tip.git, and kvm development can > >>continue on kvm.git, without the code bases diverging and requiring a merge > >>later. > >I'd like to pull the KVM bits from you into perf - so that there's a testable > >form of the changes. We can do that via a branch that has 1-2 changes, plus > >minimal conflicts down the line, right? > > We can try doing this (currently we don't, but this is simple enough that we > could). Thanks. > [...] I'd still like 1-2 in two patches. Sure. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/