Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372Ab0DRUl2 (ORCPT ); Sun, 18 Apr 2010 16:41:28 -0400 Received: from mail.perches.com ([173.55.12.10]:1517 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438Ab0DRUl1 (ORCPT ); Sun, 18 Apr 2010 16:41:27 -0400 Subject: Re: is there any chance of cleaning up the "inline" chaos? From: Joe Perches To: "Robert P. J. Day" Cc: Linux Kernel Mailing List In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Sun, 18 Apr 2010 13:41:25 -0700 Message-ID: <1271623285.1730.56.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 36 On Sun, 2010-04-18 at 16:06 -0400, Robert P. J. Day wrote: > i mean, how many different definitions of inline are necessary? > > #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \ > !defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4) > # define inline inline __attribute__((always_inline)) > # define __inline__ __inline__ __attribute__((always_inline)) > # define __inline __inline __attribute__((always_inline)) > #endif Heave to, have at it. $ git grep -w "inline" * | wc -l 35526 $ git grep -w "__inline__" * | wc -l 872 $ git grep -w "__inline" * | wc -l 17 It looks like __inline is almost exclusively in staging and should be easy to fix/change __inline__ is spread around all over the place $ git grep -wl __inline__ * | wc -l 265 It could be converted over time or in a single sweep like the recent slab changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/