Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093Ab0DSBDp (ORCPT ); Sun, 18 Apr 2010 21:03:45 -0400 Received: from adelie.canonical.com ([91.189.90.139]:50406 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545Ab0DSBDo (ORCPT ); Sun, 18 Apr 2010 21:03:44 -0400 Date: Mon, 19 Apr 2010 04:03:40 +0300 From: Amit Kucheria To: Dinh.Nguyen@freescale.com, Daniel Mack Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, s.hauer@pengutronix.de, valentin.longchamp@epfl.ch, grant.likely@secretlab.ca, bryan.wu@canonical.com, r.herring@freescale.com, Jun.Li@freescale.com, xiao-lizhang@freescale.com Subject: Re: [PATCHv4 2.6.34-rc4 5/7] mxc: Add generic USB HW initialization for MX51 Message-ID: <20100419010340.GB15308@matterhorn.verdurent.com> Mail-Followup-To: Dinh.Nguyen@freescale.com, Daniel Mack , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, s.hauer@pengutronix.de, valentin.longchamp@epfl.ch, grant.likely@secretlab.ca, bryan.wu@canonical.com, r.herring@freescale.com, Jun.Li@freescale.com, xiao-lizhang@freescale.com References: <1271445371-18501-1-git-send-email-Dinh.Nguyen@freescale.com> <1271445371-18501-2-git-send-email-Dinh.Nguyen@freescale.com> <1271445371-18501-3-git-send-email-Dinh.Nguyen@freescale.com> <1271445371-18501-4-git-send-email-Dinh.Nguyen@freescale.com> <1271445371-18501-5-git-send-email-Dinh.Nguyen@freescale.com> <20100417170706.GY30801@buzzloop.caiaq.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20100417170706.GY30801@buzzloop.caiaq.de> X-URL: http://www.verdurent.com/ User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2455 Lines: 63 On 10 Apr 17, Daniel Mack wrote: > On Fri, Apr 16, 2010 at 02:16:09PM -0500, Dinh.Nguyen@freescale.com wrote: > > This patch adds USB HW initializiation code to /plat-mxc/ehci.c. > > -Stops and resets USB HW > > -Sets some specific PHY settings > > -Stop and restart the USB HW. > > Renames mxc_set_usbcontrol to mxc_initialize_usb_hw. > > > > This patch applies to 2.6.34-rc4. > > Yes, the whole series looks _much_ better now, thanks! > Some minor things below. > > > > Signed-off-by: Dinh Nguyen > > --- > > arch/arm/plat-mxc/ehci.c | 128 ++++++++++++++++++++++++++++- > > arch/arm/plat-mxc/include/mach/mxc_ehci.h | 2 +- > > 2 files changed, 127 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/plat-mxc/ehci.c b/arch/arm/plat-mxc/ehci.c > > index cb0b638..35ff1c1 100644 > > --- a/arch/arm/plat-mxc/ehci.c > > +++ b/arch/arm/plat-mxc/ehci.c > > @@ -1,5 +1,6 @@ > > /* > > * Copyright (c) 2009 Daniel Mack > > + * Copyright (C) 2010 Freescale Semiconductor, Inc. > > * > > * This program is free software; you can redistribute it and/or modify it > > * under the terms of the GNU General Public License as published by the > > @@ -18,6 +19,7 @@ > > > > #include > > #include > > +#include > > > > #include > > #include > > @@ -50,9 +52,14 @@ > > #define MX35_H1_TLL_BIT (1 << 5) > > #define MX35_H1_USBTE_BIT (1 << 4) > > > > -int mxc_set_usbcontrol(int port, unsigned int flags) > > +int mxc_intialize_usb_hw(int port, unsigned int flags) > > This patch and the next one should be merged into one. The reason is > that you rename a function here and the next patch follows that change. > Especially when bisecting, this can lead to uncompilable checkouts of > the tree when stopping in the middle. Also, patch 3 really belongs with this patch too since the #defines in patch 3 are used here. -- ---------------------------------------------------------------------- Amit Kucheria, Kernel Engineer || amit.kucheria@canonical.com ---------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/