Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634Ab0DSJFl (ORCPT ); Mon, 19 Apr 2010 05:05:41 -0400 Received: from gir.skynet.ie ([193.1.99.77]:37814 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475Ab0DSJFj (ORCPT ); Mon, 19 Apr 2010 05:05:39 -0400 Date: Mon, 19 Apr 2010 10:05:20 +0100 From: Mel Gorman To: Christoph Lameter Cc: Pekka Enberg , KAMEZAWA Hiroyuki , Minchan Kim , Andrew Morton , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/6] change alloc function in alloc_slab_page Message-ID: <20100419090520.GN19264@csn.ul.ie> References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> <8b348d9cc1ea4960488b193b7e8378876918c0d4.1271171877.git.minchan.kim@gmail.com> <20100414091825.0bacfe48.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 30 On Fri, Apr 16, 2010 at 11:10:01AM -0500, Christoph Lameter wrote: > On Wed, 14 Apr 2010, Pekka Enberg wrote: > > > Minchan, care to send a v2 with proper changelog and reviewed-by attributions? > > Still wondering what the big deal about alloc_pages_node_exact is. Its not > exact since we can fall back to another node. It is better to clarify the > API for alloc_pages_node and forbid / clarify the use of -1. > There should be a comment clarifing it now. I admit the naming fault is mine. At the time, the intended meaning was "allocate pages from any node in the fallback list and the caller knows exactly which node to start from". I did not take into account that the meaning of "exact" depends on context. With a comment clarifying the meaning, I do not think a rename is necessary. However, I'd rather not see a mass renaming of functions like alloc_pages() that have existed a long times. If nothing else, they are documented in books like "Linux Device Drivers" so why make life harder on device authors than it already is? -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/