Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754307Ab0DSRA4 (ORCPT ); Mon, 19 Apr 2010 13:00:56 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:55493 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753589Ab0DSRAz (ORCPT ); Mon, 19 Apr 2010 13:00:55 -0400 Date: Tue, 20 Apr 2010 02:01:00 +0900 From: Mark Brown To: Axel Lin Cc: linux-kernel , Sascha Hauer , Liam Girdwood , Samuel Ortiz Subject: Re: [PATCH] mc13783-regulator: fix a memory leak in mc13783_regulator_remove Message-ID: <20100419170059.GB29819@opensource.wolfsonmicro.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You'll be sorry... User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 17 On Mon, Apr 19, 2010 at 09:58:02AM +0800, Axel Lin wrote: > This patch fixes a memory leak by freeing priv in mc13783_regulator_remove Acked-by: Mark Brown but note that... > + platform_set_drvdata(pdev, NULL); > + This is completely unrelated to what your description says (and is not needed). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/