Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959Ab0DSSih (ORCPT ); Mon, 19 Apr 2010 14:38:37 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:18476 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072Ab0DSSig (ORCPT ); Mon, 19 Apr 2010 14:38:36 -0400 Message-ID: <4BCCA315.3090009@oracle.com> Date: Mon, 19 Apr 2010 11:38:13 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: John Kacur CC: lkml , Steven Rostedt Subject: Re: trace-cmd: make Makefile rpm-friendly References: <20100419100058.6f1457dd.randy.dunlap@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090202.4BCCA31F.0183:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 28 On 04/19/10 11:11, John Kacur wrote: > > > On Mon, 19 Apr 2010, Randy Dunlap wrote: > >> From: Randy Dunlap >> >> Update Makefile to support rpmbuild DESTDIR usage. > > So, what would happen if you did > make DESTDIR=/usr/local install ? > > I think you would get /usr/local/usr/local > So, I think I would NAK this patch. > > I also don't believe there is anything magical about DESTDIR in a spec > file. Essentially, prefix in this makefile is equivalent to DESTDIR, so > you can replace DESTDIR with prefix in a spec template. I see. Thanks for your comments. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/