Subject: Re: request to add trace off and trace on with events
From: Steven Rostedt <rostedt@goodmis.org>
Reply-To: rostedt@goodmis.org
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tim Bird <tim.bird@am.sony.com>, Tom Zanussi <tzanussi@gmail.com>,
       Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       Chase Douglas <chase.douglas@canonical.com>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20100419230438.GA11493@nowhere>
References: <1271707444.10448.12.camel@gandalf.stny.rr.com>
	 <4BCCBF6D.3030105@am.sony.com>
	 <1271709846.10448.29.camel@gandalf.stny.rr.com>
	 <20100419212950.GB8811@nowhere>
	 <1271713074.10448.101.camel@gandalf.stny.rr.com>
	 <20100419220437.GC8811@nowhere>
	 <1271715227.10448.145.camel@gandalf.stny.rr.com>
	 <20100419230438.GA11493@nowhere>
Content-Type: text/plain; charset="ISO-8859-15"
Organization: Kihon Technologies Inc.
Date: Mon, 19 Apr 2010 19:59:26 -0400
Message-ID: <1271721566.10448.162.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1964
Lines: 70

On Tue, 2010-04-20 at 01:04 +0200, Frederic Weisbecker wrote:

> > # ls event/sched/sched_switch/triggers/tracing_off
> > filter   enable
> > 
> > ?
> 
> 
> That would be perhaps an overkill.

Perhaps, but I was also thinking of having triggers in the system level.
That way all events below it can trigger.

> Having a filter inside means it's on, otherwise it's off.
> 
> 
> 
> > 
> > > 
> > > > 
> > > > This could also allow a user to do:
> > > > 
> > > > echo "(a > 100)" > tracing_on
> > > > echo "(a < 100)" > tracing_off
> > > 
> > > 
> > > Yeah :)
> > > But if the scope of the "tracing off" is only for this event, then
> > > rather use:
> > > 
> > > echo "(a < 100)" > filter
> > > 
> > > You could have tracing_off/on that have this event scope and
> > > tracing_off/on_all for a global tracing scope.
> > 
> > The two are not equivalent. In fact, just enabling a trigger does not
> > mean that the event itself will be traced.
> 
> 
> Yeah, the enable file would first need to be activated before any
> trigger to take effect on the event, just like filters.
> 
> In fact I was thinking of tracing_on/tracing_off as kinds of
> local pause/resume.
> 
> And tracing_on_global/tracing_off_global would act like what does
> /debug/tracing/tracing_on: something that disables every tracing.
> 
> But of course, before any of these conditional triggers to be
> evaluated, you need to enable the corresponding event.

We could have a "trace_event_on" and "trace_event_off" trigger that only
enables the event when hit.

Actually, we can have these triggers enable other events, or make
dynamic triggers:

echo "enable_sched_switch" > events/sched/sched_wakeup/trigger/activate

or something similar.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/