Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754145Ab0DTJ7P (ORCPT ); Tue, 20 Apr 2010 05:59:15 -0400 Received: from gir.skynet.ie ([193.1.99.77]:49441 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944Ab0DTJ7O (ORCPT ); Tue, 20 Apr 2010 05:59:14 -0400 Date: Tue, 20 Apr 2010 10:58:55 +0100 From: Mel Gorman To: Minchan Kim Cc: KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "linux-mm@kvack.org" , "kosaki.motohiro@jp.fujitsu.com" Subject: Re: error at compaction (Re: mmotm 2010-04-15-14-42 uploaded Message-ID: <20100420095855.GE19264@csn.ul.ie> References: <201004152210.o3FMA7KV001909@imap1.linux-foundation.org> <20100419190133.50a13021.kamezawa.hiroyu@jp.fujitsu.com> <20100419181442.GA19264@csn.ul.ie> <20100419193919.GB19264@csn.ul.ie> <20100420082057.GC19264@csn.ul.ie> <20100420084454.GD19264@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 40 On Tue, Apr 20, 2010 at 06:50:23PM +0900, Minchan Kim wrote: > On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman wrote: > > On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote: > >> > >> Yes. Then, Let's add comment like split_page. :) > >> ?/* > >> ?* Note: this is probably too low level an operation for use in drivers. > >> ?* Please consult with lkml before using this in your driver. > >> ?*/ > >> > > > > I can, but the comment that was there says it's like split_page except the > > page is already free. This also covers not using it in a driver. > > I see. In addition, you already mentioned "As this is only being used > for migration". > I missed one. > I don't have any against one. > Will you repost v2 which move split_free_pages out of compaction.c? I don't understand your suggestion. split_free_pages is already out of compaction.c. > Anyway, feel free to add my reviewed-by sign. > Thanks, Mel. > > Reviewed-by: Minchan Kim > Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/