Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790Ab0DTQws (ORCPT ); Tue, 20 Apr 2010 12:52:48 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:36196 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899Ab0DTQwr (ORCPT ); Tue, 20 Apr 2010 12:52:47 -0400 Date: Tue, 20 Apr 2010 12:52:25 -0400 From: Jeff Dike To: Jiri Kosina Cc: Amerigo Wang , Jan Kiszka , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition Message-ID: <20100420165225.GA31439@c-98-229-117-200.hsd1.ma.comcast.net> References: <74c7d668690f283cf3b8aed92004dc72e872f7ce.1271713955.git.jan.kiszka@web.de> <20100420083358.GD4356@cr0.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 22 On Tue, Apr 20, 2010 at 04:35:52PM +0200, Jiri Kosina wrote: > On Tue, 20 Apr 2010, Amerigo Wang wrote: > > Shouldn't this signal.c #include ? > > Well, it gets included implicitly through uaccess.h -> sched.h -> > kernel.h. You're depending on the internal details of uaccess.h and sched.h. If either of them changed, then this would cause unexpected compile failures here. Better to explicitly include kernel.h. Jeff -- Work email - jdike at linux dot intel dot com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/