Date: Tue, 20 Apr 2010 19:18:04 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.cz>
To: Jeff Dike <jdike@addtoit.com>
Cc: Amerigo Wang <xiyou.wangcong@gmail.com>, Jan Kiszka <jan.kiszka@web.de>,
       linux-kernel@vger.kernel.org,
       user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down
 definition
In-Reply-To: <20100420165225.GA31439@c-98-229-117-200.hsd1.ma.comcast.net>
Message-ID: <alpine.LNX.2.00.1004201917520.7579@pobox.suse.cz>
References: <cover.1271713955.git.jan.kiszka@web.de> <74c7d668690f283cf3b8aed92004dc72e872f7ce.1271713955.git.jan.kiszka@web.de> <20100420083358.GD4356@cr0.nay.redhat.com> <alpine.LNX.2.00.1004201635050.7579@pobox.suse.cz>
 <20100420165225.GA31439@c-98-229-117-200.hsd1.ma.comcast.net>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 723
Lines: 25

On Tue, 20 Apr 2010, Jeff Dike wrote:

> > > Shouldn't this signal.c #include <linux/kernel.h>?
> > 
> > Well, it gets included implicitly through uaccess.h -> sched.h -> 
> > kernel.h.
> 
> You're depending on the internal details of uaccess.h and sched.h.  If
> either of them changed, then this would cause unexpected compile
> failures here.
> 
> Better to explicitly include kernel.h.

Yeah, I have that already in my tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/