Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611Ab0DUGIV (ORCPT ); Wed, 21 Apr 2010 02:08:21 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:52204 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231Ab0DUGIU (ORCPT ); Wed, 21 Apr 2010 02:08:20 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=wTdDQ2jxEzWPWCKod6OKtCgJ+wuslXAvDVOHeEOWKCd+8gMv1wdnOiuu0281ZBRfmE nViouvK4TQXo5cQyjxFBgvLcGgt9HGa701SDIEKUxLvGZkoQtPTO2a95AbxeA6XsAKNB XSziscaLEbB982pasZsfaCEPka7PH8PmiW4/I= Date: Wed, 21 Apr 2010 14:12:05 +0800 From: Amerigo Wang To: Jan Kiszka Cc: Amerigo Wang , trivial@kernel.org, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, Jeff Dike Subject: Re: [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls Message-ID: <20100421061205.GC4467@cr0.nay.redhat.com> References: <3e07ad1a38e88a22d7298deb88a8f3962b101998.1271713955.git.jan.kiszka@web.de> <20100420101056.GC5317@cr0.nay.redhat.com> <4BCDE103.7080709@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BCDE103.7080709@web.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 35 On Tue, Apr 20, 2010 at 07:14:43PM +0200, Jan Kiszka wrote: >Amerigo Wang wrote: >> On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote: >>> The i386 subarch happens to pull in original NR_syscalls. Maybe we can >>> make that work for all host arch, but for now just avoid the clash by >>> using an all-upper-case name. >>> >> >> Where? > >Not sure if this answers your question: > > CC arch/um/kernel/skas/syscall.o >/data/linux-2.6/arch/um/kernel/skas/syscall.c:13:1: warning: >"NR_syscalls" redefined >In file included from /data/linux-2.6/arch/x86/include/asm/unistd.h:3, > from >/data/linux-2.6/arch/um/sys-i386/shared/sysdep/syscalls.h:6, > from /data/linux-2.6/arch/um/kernel/skas/syscall.c:10: >/data/linux-2.6/arch/x86/include/asm/unistd_32.h:349:1: warning: this is >the location of the previous definition > Ah, sure. I misunderstood your purpose, please do include the warning messages you are trying to fix in your patch description. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/