Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754167Ab0DUKsO (ORCPT ); Wed, 21 Apr 2010 06:48:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54915 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754044Ab0DUKsM (ORCPT ); Wed, 21 Apr 2010 06:48:12 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20100421012749.GA21338@us.ibm.com> References: <20100421012749.GA21338@us.ibm.com> To: "Serge E. Hallyn" Cc: dhowells@redhat.com, lkml , Ashwin Ganti , Greg KH , rsc@swtch.com, ericvh@gmail.com, linux-security-module@vger.kernel.org, Ron Minnich , jt.beard@gmail.com, Andrew Morton , Andrew Morgan , oleg@us.ibm.com, Eric Paris , "Eric W. Biederman" Subject: Re: [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions Date: Wed, 21 Apr 2010 11:46:57 +0100 Message-ID: <23079.1271846817@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 20 Serge E. Hallyn wrote: > +int cred_setresuid(struct cred *new, uid_t ruid, uid_t euid, uid_t suid, > + int force); > +int cred_setresgid(struct cred *new, gid_t rgid, gid_t egid, gid_t sgid, > + int force); > +int cred_setfsuid(struct cred *new, uid_t uid, uid_t *old_fsuid); > +int cred_setfsgid(struct cred *new, gid_t gid, gid_t *old_fsgid); Can you mark these extern please? Other than that, these functions should probably be mentioned in Documentation/credentials.txt. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/