Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589Ab0DULrU (ORCPT ); Wed, 21 Apr 2010 07:47:20 -0400 Received: from soto.provo.novell.com ([137.65.250.214]:38858 "EHLO soto.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035Ab0DULrR convert rfc822-to-8bit (ORCPT ); Wed, 21 Apr 2010 07:47:17 -0400 Message-Id: <4BCEAD7B0200005A0006513E@soto.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.1 Date: Wed, 21 Apr 2010 05:47:07 -0600 From: "Gregory Haskins" To: "Peter Zijlstra" , "John Kacur" Cc: "Ingo Molnar" , "Thomas Gleixner" , "Andrew Morton" , "Luis Claudio R. Goncalves" , "Clark Williams" , , Subject: Re: [PATCH v3] lockdep: Make MAX_STACK_TRACE_ENTRIES configurable. References: <20100420140941.d085007d.akpm@linux-foundation.org> <1271849823.1776.87.camel@laptop> In-Reply-To: <1271849823.1776.87.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1822 Lines: 46 >>> On 4/21/2010 at 07:37 AM, in message <1271849823.1776.87.camel@laptop>, Peter Zijlstra wrote: > On Wed, 2010-04-21 at 13:12 +0200, John Kacur wrote: >> >> Certain configurations that have LOCKDEP turned on, run into the limit >> where the MAX_STACK_TRACE_ENTRIES are too small. Rather than simply >> turning of the locking correctness validator let the user configure this >> value to something reasonable for their system. > > I'm not sure its worth having a CONFIG_ value for this, that'll just be > yet another random value nobody knows what to do with. > > Do you actually have a machine that reproduces this? Can you see how > many classes, avg stacktraces per class and the avg entries per > stacktrace there are? > > Also, is there's lots of classes, are there many with a similar name? > > That is, is it a valid depletion or is there something wonkey with those > setups? Hi John, Peter. I am not sure if Johns solution is the right/best one per se, but I can attest that I used to hit this problem _all_ the time and it was somewhat annoying to need to patch the kernel on all of my machines to fix it. I realize that I perhaps do not represent the average user, but it was a pain-point for me. FWIW, John's patch would indeed make my life easier since I tend to share the .config between builds. Kind Regards, -Greg > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/