Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755478Ab0DUOzS (ORCPT ); Wed, 21 Apr 2010 10:55:18 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:54986 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753495Ab0DUOzQ (ORCPT ); Wed, 21 Apr 2010 10:55:16 -0400 Date: Wed, 21 Apr 2010 16:55:14 +0200 From: Jens Axboe To: Vivek Goyal Cc: linux kernel mailing list , Divyesh Shah , Nauman Rafique , Gui Jianfeng Subject: Re: [PATCH] blkio: Fix a crash during rq stats update Message-ID: <20100421145514.GT27497@kernel.dk> References: <20100421144550.GA3275@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100421144550.GA3275@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 45 On Wed, Apr 21 2010, Vivek Goyal wrote: > @@ -1001,6 +1002,10 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create) > return cfqg; > } > > +static inline void cfq_get_cfqg_ref(struct cfq_group *cfqg) { > + atomic_inc(&cfqg->ref); > +} Would be nicer as static inline void cfq_ref_get_cfqg(struct cfq_group *cfqg) { atomic_inc(&cfqg->ref); return cfqg; } ... static inline void cfq_ref_get_cfqg(struct cfq_group *cfqg) { return NULL; } ... > @@ -3560,6 +3570,9 @@ new_queue: > > rq->elevator_private = cic; > rq->elevator_private2 = cfqq; > + rq->elevator_private3 = cfqq->cfqg; > + /* rq reference on cfqg */ > + cfq_get_cfqg_ref(RQ_CFQG(rq)); > return 0; rq->elevator_private3 = cfq_ref_get_cfqg(...); -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/