Date: Wed, 21 Apr 2010 17:14:01 +0200
From: Jens Axboe <jens.axboe@oracle.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
       Divyesh Shah <dpshah@google.com>, Nauman Rafique <nauman@google.com>,
       Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Subject: Re: [PATCH] blkio: Fix a crash during rq stats update
Message-ID: <20100421151400.GU27497@kernel.dk>
References: <20100421144550.GA3275@redhat.com> <20100421145514.GT27497@kernel.dk> <20100421151115.GB3275@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100421151115.GB3275@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 41

On Wed, Apr 21 2010, Vivek Goyal wrote:
> On Wed, Apr 21, 2010 at 04:55:14PM +0200, Jens Axboe wrote:
> > On Wed, Apr 21 2010, Vivek Goyal wrote:
> > > @@ -1001,6 +1002,10 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create)
> > >  	return cfqg;
> > >  }
> > >  
> > > +static inline void cfq_get_cfqg_ref(struct cfq_group *cfqg) {
> > > +	atomic_inc(&cfqg->ref);
> > > +}
> > 
> > Would be nicer as
> > 
> > static inline void cfq_ref_get_cfqg(struct cfq_group *cfqg)
> > {
> 
> Chagne of name, will do.
> 
> > 	atomic_inc(&cfqg->ref);
> >         return cfqg;
> > }
> 
> So you want to return cfqg pointer here instead of return type being void?

Yeah of course, too much copy-paste.

> Will fix it.
> 
> Ok, so in case of CFQ_GROUP_IOSCHED, return a poitner to cfqg upon getting
> the reference, otherwise NULL. Will fix it.

Exactly, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/