Date: Wed, 21 Apr 2010 11:47:17 -0400
From: Vivek Goyal <vgoyal@redhat.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
       Divyesh Shah <dpshah@google.com>, Nauman Rafique <nauman@google.com>,
       Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Subject: Re: [PATCH V2] blkio: Fix blkio crash during rq stat update
Message-ID: <20100421154717.GE3275@redhat.com>
References: <20100421153623.GD3275@redhat.com> <20100421154101.GV27497@kernel.dk> <20100421154127.GW27497@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100421154127.GW27497@kernel.dk>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 849
Lines: 29

On Wed, Apr 21, 2010 at 05:41:28PM +0200, Jens Axboe wrote:
> On Wed, Apr 21 2010, Jens Axboe wrote:
> > On Wed, Apr 21 2010, Vivek Goyal wrote:
> > > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create)
> > >  	return cfqg;
> > >  }
> > >  
> > > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) {
> > > +	atomic_inc(&cfqg->ref);
> > > +	return cfqg;
> > > +}
> > > +
> > 
> > Sorry to keep harping on this - style is still wrong, and:
> 
> I'll fix these up by hand.

Thanks Jens. Sorry for the trouble.

Vivek

> 
> -- 
> Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/