Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972Ab0DUQ3b (ORCPT ); Wed, 21 Apr 2010 12:29:31 -0400 Received: from mail-pz0-f186.google.com ([209.85.222.186]:44285 "EHLO mail-pz0-f186.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755878Ab0DUQ3a (ORCPT ); Wed, 21 Apr 2010 12:29:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=GKcMnRfFImpZUQgCwy5pEzVP3gL8kf/5H3MvstJr/e4ZZlyxP4Lx4clUfg1DcBdN6a GZQ02kegRgVn/2f359K+N328hWKw6GNjlUUve25bfBfodYU0r/yOuvxmJdKtfvf5wceL ji94lh9LR1WqgQkMwrHqoY7JE/TuEHy1x2VgE= Date: Thu, 22 Apr 2010 00:33:37 +0800 From: =?utf-8?Q?Am=C3=A9rico?= Wang To: Guennadi Liakhovetski Cc: =?utf-8?Q?Am=C3=A9rico?= Wang , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore Message-ID: <20100421163337.GD13861@hack> References: <20100421152837.GA13861@hack> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 28 On Wed, Apr 21, 2010 at 05:31:34PM +0200, Guennadi Liakhovetski wrote: >On Wed, 21 Apr 2010, Américo Wang wrote: > >> On Wed, Apr 21, 2010 at 01:47:29PM +0200, Guennadi Liakhovetski wrote: >> >Tell git to ignore .rej files, generated by patch(1). >> > >> >Signed-off-by: Guennadi Liakhovetski >> >> NACK. >> >> You have to handle *.rej files, not leaving them there. > >Hm? I know I have to handle them, and I do handle them, but IMHO it's >entirely valid and up to the user to leave them where they are. You could >apply similar argument to *.orig or to *~ files. In other words, I'm not >convinced. > I am not the only people who is against this, there was a discussion about this before, please search lkml archive. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/