Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753705Ab0DVJ3d (ORCPT ); Thu, 22 Apr 2010 05:29:33 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:58284 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753480Ab0DVJ3c (ORCPT ); Thu, 22 Apr 2010 05:29:32 -0400 Message-ID: <4BD01768.2020606@cn.fujitsu.com> Date: Thu, 22 Apr 2010 17:31:20 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: LKML CC: "containers@lists.osdl.org" , "Paul E. McKenney" , Paul Menage , Andrew Morton , Matt Helsley , Cedric Le Goater Subject: [PATCH 4/5] freezer cgroup: Fix an RCU warning in cgroup_freezing_or_frozen() References: <4BD016F4.8060108@cn.fujitsu.com> In-Reply-To: <4BD016F4.8060108@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 43 with CONFIG_PROVE_RCU, a warning can be triggered when we resume from suspend: ... include/linux/cgroup.h:533 invoked rcu_dereference_check() without protection! ... task_freezer() calls task_subsys_state(), which needs to be protected by rcu_read_lock or cgroup_mutex. Signed-off-by: Li Zefan --- kernel/cgroup_freezer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c index 5038f4c..ac76983 100644 --- a/kernel/cgroup_freezer.c +++ b/kernel/cgroup_freezer.c @@ -53,6 +53,7 @@ int cgroup_freezing_or_frozen(struct task_struct *task) struct freezer *freezer; enum freezer_state state; + rcu_read_lock(); task_lock(task); freezer = task_freezer(task); if (!freezer->css.cgroup->parent) @@ -60,6 +61,7 @@ int cgroup_freezing_or_frozen(struct task_struct *task) else state = freezer->state; task_unlock(task); + rcu_read_unlock(); return (state == CGROUP_FREEZING) || (state == CGROUP_FROZEN); } -- 1.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/