Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787Ab0DVKUM (ORCPT ); Thu, 22 Apr 2010 06:20:12 -0400 Received: from casper.infradead.org ([85.118.1.10]:35692 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319Ab0DVKUJ (ORCPT ); Thu, 22 Apr 2010 06:20:09 -0400 Subject: Re: [PATCH 3/5] sched: Fix an RCU warning in print_task() From: Peter Zijlstra To: Li Zefan Cc: LKML , "containers@lists.osdl.org" , "Paul E. McKenney" , Paul Menage , Andrew Morton , Ingo Molnar In-Reply-To: <4BD01740.7050805@cn.fujitsu.com> References: <4BD016F4.8060108@cn.fujitsu.com> <4BD01740.7050805@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 22 Apr 2010 12:20:04 +0200 Message-ID: <1271931604.1776.337.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 48 On Thu, 2010-04-22 at 17:30 +0800, Li Zefan wrote: > With CONFIG_PROVE_RCU=y, a warning can be triggered: > > $ cat /proc/sched_debug > > ... > kernel/cgroup.c:1649 invoked rcu_dereference_check() without protection! > ... > > Both cgroup_path() and task_group() should be called with either > rcu_read_lock or cgroup_mutex held. Well, that's not strictly true, but yes in this case it appears to be a genuine race, since only tasklist_lock is held and that doesn't protect us from the task changing groups (and thus the current group from going away on us). You can also pin a cgroup by holding whatever locks are held in the ->attach method. But the RCU annotation doesn't know (nor reasonably can know about that). > Signed-off-by: Li Zefan > --- > kernel/sched_debug.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/kernel/sched_debug.c b/kernel/sched_debug.c > index 9cf1baf..87a330a 100644 > --- a/kernel/sched_debug.c > +++ b/kernel/sched_debug.c > @@ -114,7 +114,9 @@ print_task(struct seq_file *m, struct rq *rq, struct task_struct *p) > { > char path[64]; > > + rcu_read_lock(); > cgroup_path(task_group(p)->css.cgroup, path, sizeof(path)); > + rcu_read_unlock(); > SEQ_printf(m, " %s", path); > } > #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/