Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756038Ab0DVSDu (ORCPT ); Thu, 22 Apr 2010 14:03:50 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:27624 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753821Ab0DVSDs (ORCPT ); Thu, 22 Apr 2010 14:03:48 -0400 Date: Thu, 22 Apr 2010 11:02:14 -0700 From: Randy Dunlap To: James Bottomley , Ravi Anand Cc: Andrew Morton , Linus Torvalds , linux-scsi , linux-kernel@vger.kernel.org, David C Somayajulu , Karen Higgins , Vikas Chaudhary Subject: [PATCH 3rd_time] scsi: fix operator precedence warning Message-Id: <20100422110214.e7c62688.randy.dunlap@oracle.com> In-Reply-To: <1271945825.2889.138.camel@mulgrave.site> References: <1271945825.2889.138.camel@mulgrave.site> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090209.4BD08F71.0033:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 33 From: Randy Dunlap Fix operator precedence warning (from sparse), which results in the data value always being 0: drivers/scsi/qla4xxx/ql4_mbx.c:470:66: warning: right shift by bigger than source value Signed-off-by: Randy Dunlap Acked-by: Ravi Anand Cc: David C Somayajulu Cc: Karen Higgins Cc: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.34-rc3-git5.orig/drivers/scsi/qla4xxx/ql4_mbx.c +++ linux-2.6.34-rc3-git5/drivers/scsi/qla4xxx/ql4_mbx.c @@ -467,7 +467,7 @@ int qla4xxx_get_fwddb_entry(struct scsi_ if (conn_err_detail) *conn_err_detail = mbox_sts[5]; if (tcp_source_port_num) - *tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16; + *tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16); if (connection_id) *connection_id = (uint16_t) mbox_sts[6] & 0x00FF; status = QLA_SUCCESS; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/