Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753477Ab0DVWrM (ORCPT ); Thu, 22 Apr 2010 18:47:12 -0400 Received: from tundra.namei.org ([65.99.196.166]:43381 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306Ab0DVWrJ (ORCPT ); Thu, 22 Apr 2010 18:47:09 -0400 Date: Fri, 23 Apr 2010 08:46:27 +1000 (EST) From: James Morris To: Andrew Morton cc: David Howells , linux-security-module@vger.kernel.org, mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] CRED: Fix double free in prepare_usermodehelper_creds() error handling In-Reply-To: <20100422112307.5375e085.akpm@linux-foundation.org> Message-ID: References: <20100420214117.10400.82534.stgit@warthog.procyon.org.uk> <20100422112307.5375e085.akpm@linux-foundation.org> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 581 Lines: 19 On Thu, 22 Apr 2010, Andrew Morton wrote: > > #ifdef CONFIG_KEYS > > kfree(tgcred); > > Oleg's umh-creds-kill-subprocess_info-cred-logic.patch removes > prepare_usermodehelper_creds() altogether. An option would have been > to promote that into 2.6.34? FYI, this fix is in Linus' tree, now. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/