Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757600Ab0DWPNt (ORCPT ); Fri, 23 Apr 2010 11:13:49 -0400 Received: from fg-out-1718.google.com ([72.14.220.159]:2109 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756937Ab0DWPNX (ORCPT ); Fri, 23 Apr 2010 11:13:23 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; b=laSkPP36m0Bp0Vn4Z96D4Fe9UxNtxQOt9hVLk5riX2d5+Q3zWp81rVl7IUOmv/SmxB lPTEFHss9E5xKQgZleL9Avd70eo4epjQQGST5162bocGJwkOF4f1nuFUkHajFiMwPwN8 7JFjzs6FXfR5db3cFeqvbvMw5Xs1dVVRW0qEY= Subject: Re: [PATCH v2] MTD: Fix Orion NAND driver compilation with ARM OABI From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Nicolas Pitre Cc: Paulius Zaleckas , dwmw2@infradead.org, jamie@shareable.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, u.kleine-koenig@pengutronix.de, simon.kagstrom@netinsight.net, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org In-Reply-To: References: <20100325152505.17612.40158.stgit@pauliusz> <4BB33988.9070608@gmail.com> <1272023778.6917.6.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Fri, 23 Apr 2010 18:13:16 +0300 Message-Id: <1272035596.11751.1437.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1715 Lines: 44 On Fri, 2010-04-23 at 08:54 -0400, Nicolas Pitre wrote: > On Fri, 23 Apr 2010, Artem Bityutskiy wrote: > > > On Wed, 2010-03-31 at 15:01 +0300, Paulius Zaleckas wrote: > > > On 03/25/2010 06:26 PM, Nicolas Pitre wrote: > > > > On Thu, 25 Mar 2010, Paulius Zaleckas wrote: > > > > > > > >> We must tell GCC to use even register for variable passed > > > >> to ldrd instruction. Without this patch GCC 4.2.1 puts this > > > >> variable to r2/r3 on EABI and r3/r4 on OABI, so force it to > > > >> r2/r3. This does not change anything when EABI and OABI > > > >> compilation works OK. > > > >> > > > >> Without this patch and with OABI I get: > > > >> CC drivers/mtd/nand/orion_nand.o > > > >> /tmp/ccMkwOCs.s: Assembler messages: > > > >> /tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]' > > > >> make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1 > > > >> > > > >> Signed-off-by: Paulius Zaleckas > > > > > > > > Acked-by: Nicolas Pitre > > > > > > David, > > > > > > Will you take this patch? > > > Or you are waiting till I will add all Cc as Jamie suggested? > > > > Meanwhile, I've pushed your patch to my l2-mtd-2.6.git / dunno. > > I think it should go to mainline. It is not perfect, but still better > than the current situation. Fine with me, but not up to me. But I guess Andrew could merge it. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/