Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755255Ab0DXCQE (ORCPT ); Fri, 23 Apr 2010 22:16:04 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:36856 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565Ab0DXCQA convert rfc822-to-8bit (ORCPT ); Fri, 23 Apr 2010 22:16:00 -0400 MIME-Version: 1.0 In-Reply-To: References: <1271984938-13920-2-git-send-email-arve@android.com> Date: Fri, 23 Apr 2010 19:15:59 -0700 Message-ID: Subject: Re: [PATCH 1/9] PM: Add suspend block api. From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Alan Stern Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Len Brown , Pavel Machek , "Rafael J. Wysocki" , Randy Dunlap , Jesse Barnes , Magnus Damm , Nigel Cunningham , Cornelia Huck , Ming Lei , Wu Fengguang , Andrew Morton , Maxim Levitsky , linux-doc@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 24 2010/4/23 Alan Stern : > On Thu, 22 Apr 2010, [UTF-8] Arve Hj?nnev?g wrote: ... >> +Calling suspend_block when the suspend blocker is active or suspend_unblock when >> +it is not active has no effect. This allows drivers to update their state and >> +call suspend suspend_block or suspend_unblock based on the result. > > But suspend_block() and suspend_unblock() don't nest. ?You should > mention this. > I'm not sure what you mean by this? I think the first sentence dictates nesting is not supported. I think the rest of your comments will be addressed in the next version of the document, that I worked with Rafael on. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/