Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754195Ab0DXCaw (ORCPT ); Fri, 23 Apr 2010 22:30:52 -0400 Received: from netrider.rowland.org ([192.131.102.5]:51929 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752562Ab0DXCau (ORCPT ); Fri, 23 Apr 2010 22:30:50 -0400 Date: Fri, 23 Apr 2010 22:30:49 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= cc: Linux-pm mailing list , Kernel development list , Len Brown , Pavel Machek , "Rafael J. Wysocki" , Randy Dunlap , Jesse Barnes , Nigel Cunningham , Cornelia Huck , Ming Lei , Wu Fengguang , Andrew Morton , Maxim Levitsky , Subject: Re: [PATCH 1/9] PM: Add suspend block api. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 31 On Fri, 23 Apr 2010, Arve Hj?nnev?g wrote: > 2010/4/23 Alan Stern : > > On Thu, 22 Apr 2010, [UTF-8] Arve Hj?nnev?g wrote: > ... > >> +Calling suspend_block when the suspend blocker is active or suspend_unblock when > >> +it is not active has no effect. This allows drivers to update their state and > >> +call suspend suspend_block or suspend_unblock based on the result. > > > > But suspend_block() and suspend_unblock() don't nest. ?You should > > mention this. > > > > I'm not sure what you mean by this? I think the first sentence > dictates nesting is not supported. That fact is implicit from the first sentence. Mentioning it _explicitly_ will help people to understand more easily. You don't have to add much; a parenthetical remark would be enough: Calling suspend_block when the suspend blocker is active or suspend_unblock when it is not active has no effect (i.e., these functions don't nest). This allows drivers to ... Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/