Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751220Ab0DXE1p (ORCPT ); Sat, 24 Apr 2010 00:27:45 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:41960 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747Ab0DXE1n (ORCPT ); Sat, 24 Apr 2010 00:27:43 -0400 Date: Fri, 23 Apr 2010 21:27:39 -0700 From: "Paul E. McKenney" To: KAMEZAWA Hiroyuki Cc: Li Zefan , Balbir Singh , Daisuke Nishimura , "linux-mm@kvack.org" , LKML , "akpm@linux-foundation.org" Subject: Re: [BUGFIX][PATCH] memcg rcu lock fix v3 Message-ID: <20100424042739.GD2589@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <4BD10D59.9090504@cn.fujitsu.com> <20100423121424.ae47efcb.kamezawa.hiroyu@jp.fujitsu.com> <4BD118E2.7080307@cn.fujitsu.com> <4BD11A24.2070500@cn.fujitsu.com> <20100423125814.01e95bce.kamezawa.hiroyu@jp.fujitsu.com> <20100423130349.f320d0be.kamezawa.hiroyu@jp.fujitsu.com> <20100423193406.GD2589@linux.vnet.ibm.com> <20100424110805.17c7f86e.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100424110805.17c7f86e.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2099 Lines: 59 On Sat, Apr 24, 2010 at 11:08:05AM +0900, KAMEZAWA Hiroyuki wrote: > On Fri, 23 Apr 2010 12:34:06 -0700 > "Paul E. McKenney" wrote: > > > On Fri, Apr 23, 2010 at 01:03:49PM +0900, KAMEZAWA Hiroyuki wrote: > > > On Fri, 23 Apr 2010 12:58:14 +0900 > > > KAMEZAWA Hiroyuki wrote: > > > > > > > On Fri, 23 Apr 2010 11:55:16 +0800 > > > > Li Zefan wrote: > > > > > > > > > Li Zefan wrote: > > > > > > KAMEZAWA Hiroyuki wrote: > > > > > >> On Fri, 23 Apr 2010 11:00:41 +0800 > > > > > >> Li Zefan wrote: > > > > > >> > > > > > >>> with CONFIG_PROVE_RCU=y, I saw this warning, it's because > > > > > >>> css_id() is not under rcu_read_lock(). > > > > > >>> > > > > > >> Ok. Thank you for reporting. > > > > > >> This is ok ? > > > > > > > > > > > > Yes, and I did some more simple tests on memcg, no more warning > > > > > > showed up. > > > > > > > > > > > > > > > > oops, after trigging oom, I saw 2 more warnings: > > > > > > > > > > > > > Thank you for good testing. > > > v3 here...sorry too rapid posting... > > > > > > == > > > From: KAMEZAWA Hiroyuki > > > > I have queued this, thank you all! > > > > However, memcg_oom_wake_function() does not yet exist in the tree > > I am using, and is_target_pte_for_mc() has changed. I omitted the > > hunk for memcg_oom_wake_function() and edited the hunk for > > is_target_pte_for_mc(). > > > Ok, memcg_oom_wake_function is for -mm. I'll prepare another patch for -mm. > > > > I have queued this for others' testing, but if you would rather carry > > this patch up the memcg path, please let me know and I will drop it. > > > I think it's ok to be fixed by your tree. I'll look at memcg later and > fix remaining things. Sounds good! Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/