Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753473Ab0DXStd (ORCPT ); Sat, 24 Apr 2010 14:49:33 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42007 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179Ab0DXStc (ORCPT ); Sat, 24 Apr 2010 14:49:32 -0400 Date: Sat, 24 Apr 2010 11:47:17 -0700 (PDT) From: Linus Torvalds To: Frederic Weisbecker cc: LKML , Arnd Bergmann , Thomas Gleixner , Al Viro , Jan Blunck , Ingo Molnar , John Kacur Subject: Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal In-Reply-To: Message-ID: References: <1271390201-20431-1-git-send-regression-fweisbec@gmail.com> <1271897282-11207-1-git-send-regression-fweisbec@gmail.com> <20100424152542.GD5545@nowhere> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 26 On Sat, 24 Apr 2010, Linus Torvalds wrote: > > I don't see the point, frankly. Especially not outside the merge window, > but quite frankly, I don't see it in general. The whole thing seems to be > designed to be inconvenient, and to have a config option that I > fundamentally don't believe in (CONFIG_BKL). More detail: it still leaves that old "ioctl" function pointer that needs the BKL and is ungreppable. So the whole and only point of the patch is to make our current mess even _more_ complex, with three different cases. No, thank you. Quite frankly, if you want to get rid of the BKL in ioctl's and make them easily greppable, then I would suggest a simple renaming: rename the current '->ioctl()' thing to '->bkl_ioctl()', and mark it deprecated. No new config options, no new games. Just rename it. No need to mark things with CONFIG_BKL, when you can just see it by virtue of them using 'bkl_ioctl'. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/