Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016Ab0DYP32 (ORCPT ); Sun, 25 Apr 2010 11:29:28 -0400 Received: from netrider.rowland.org ([192.131.102.5]:55826 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752841Ab0DYP31 (ORCPT ); Sun, 25 Apr 2010 11:29:27 -0400 Date: Sun, 25 Apr 2010 11:29:24 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= , Dmitry Torokhov , Randy Dunlap , =?iso-8859-1?q?M=E1rton_N=E9meth?= , Thadeu Lima de Souza Cascardo , , Sven Neumann , , Henrik Rydberg , Jiri Kosina , , Tero Saarni , Matthew Garrett Subject: Re: [linux-pm] [PATCH 8/9] Input: Block suspend while event queue is not empty. In-Reply-To: <201004250430.31054.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 34 On Sun, 25 Apr 2010, Rafael J. Wysocki wrote: > On Saturday 24 April 2010, Alan Stern wrote: > > On Fri, 23 Apr 2010, Arve Hj?nnev?g wrote: > > > > > On Fri, Apr 23, 2010 at 2:08 PM, Dmitry Torokhov > > > wrote: > > > > On Friday 23 April 2010 01:56:25 pm Randy Dunlap wrote: > > > >> On Thu, 22 Apr 2010 18:08:57 -0700 Arve Hj?nnev?g wrote: > > > >> > Add an ioctl, EVIOCSSUSPENDBLOCK, to enable a suspend_blocker that will > > > >> > block suspend while the event queue is not empty. This allows userspace > > > >> > code to process input events while the device appears to be asleep. > > Is there some reason why this feature needs to be enabled by an > > ioctl? Why not make this suspend blocker permanently enabled? > > The ioctl is there so that user space can use suspend blockers, which is > needed because only user space know that some activities are going to continue > and therefore the system should not be suspended (like playing music "in the > background"). No, you're thinking of a different ioctl: SUSPEND_BLOCKER_IOCTL_BLOCK. This one (EVIOCSSUSPENDBLOCK) is present _only_ to enable one specific suspend blocker, which is activated when the input event queue is non-empty. I don't see any reason why it shouldn't be enabled all the time. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/