Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416Ab0DYQkG (ORCPT ); Sun, 25 Apr 2010 12:40:06 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:60583 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679Ab0DYQkE (ORCPT ); Sun, 25 Apr 2010 12:40:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=RlTUkLHcMqsu9ds1MAwl/c2hSWSCWzxAXkMEDoYLio4Ku0PyZ3XqYvML/nS0QUWHEJ PlBR+MTTQGPdlc15RVgLTJFNMEXgjgsy4zoJzbOTPQmDaQqnl9DYcPFVMmnP5SLrogRL CTXYislVEymD4zGGyt/GAzLmAOFo2hcJHnST0= Subject: Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] From: Eric Dumazet To: piotr@hosowicz.com Cc: sedat.dilek@gmail.com, Sedat Dilek , LKML , netdev@vger.kernel.org, David Miller , Jiri Olsa , Jongman Heo In-Reply-To: <4BD46F9C.5060500@example.com> References: <4BD45E68.4080900@example.com> <4BD46F9C.5060500@example.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 25 Apr 2010 18:39:57 +0200 Message-ID: <1272213597.2069.32.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 50 Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : > On 25.04.2010 18:31, Sedat Dilek wrote: > > [ CCing netdev ML ] > > > > Confirmed: The revert-patch [1] fixes the problem here. > > I confirm, I've built a git6 kernel and it works fine. > > > See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. > > > > Feel free to add a... Tested-by: Sedat Dilek > > I added created and tested phrase in my archive. ;-) Thank you a lot. I > hope there will be no this error in git7. > Did you test the proposed fix ? [PATCH] ipv6: Fix inet6_csk_bind_conflict() Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) introduced a bug on IPV6 part. We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is IPV6. Reported-by: Michael S. Tsirkin Signed-off-by: Eric Dumazet --- diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index b4b7d40..3a4d92b 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_sock.c @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, ipv6_rcv_saddr_equal(sk, sk2)) break; else if (sk->sk_reuse && sk2->sk_reuse && - !ipv6_addr_any(inet6_rcv_saddr(sk2)) && + !ipv6_addr_any(inet6_rcv_saddr(sk)) && ipv6_rcv_saddr_equal(sk, sk2)) break; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/